Modify the way credentials are obtained for mysqldump in script delete_imaging_upload.pl #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_imaging_upload.pl
cmadjar
approved these changes
May 9, 2025
MaximeBICMTL
pushed a commit
to maximemulder/Loris-MRI
that referenced
this pull request
Jun 16, 2025
…e_imaging_upload.pl (aces#1282) * Modify the way credentials are obtained for mysqldump in script delete_imaging_upload.pl * Remove debug print statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the behavior of script
delete_imaging_upload.plin the following way: it removes option-extra_mysqlcnfand adds an option-mysql-defaults-filethat can be used to specify a file containing the password to use whenmysqldumpis invoked with a non-admin user (the one specified in theprodfile). The big difference here is that the file specified with that new option will be the only one read to get this password. This avoids potential conflicts when there already is a~/.my.cnfoption file with a different password in it (e.g. to run amysqlclient with an admin user). See https://dev.mysql.com/doc/refman/8.4/en/option-files.html.